Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHO CCIP Base Expansion #20

Closed
wants to merge 84 commits into from
Closed

GHO CCIP Base Expansion #20

wants to merge 84 commits into from

Conversation

DhairyaSethi
Copy link
Member

@DhairyaSethi DhairyaSethi commented Dec 23, 2024 •
edited
Loading

Goal

https://governance.aave.com/t/arfc-launch-gho-on-base-set-aci-as-emissions-manager-for-rewards/19338

This AIP aims to expand GHO token to base using CCIP, through lanes between existing ETH & ARB chains. It also aims to list GHO as a borrowable asset on Aave V3 Base.
The AIP includes two proposals for base (launch, listing), to be executed separately (hence two payloads are generated for base) since GHO will be bridged to Executor on Base after launch to initiate listing.

Launch Steps:

  • ARB:
    • Configure new BASE lane (while retaining existing ETH lane) with rate limit (300k capacity, 60 rate; same as ETH).
    • Update ProxyAdmin of GHO token to oz 5.1 style ProxyAdmin.
  • ETH: Configure new BASE lane (while retaining existing ARB lane) with rate limit (300k capacity, 60 rate; same as ARB).
  • BASE:
    • Configure new ETH & ARB lanes with rate limit (300k capacity, 60 rate).
    • Configure all stewards.

Listing Steps:

  • BASE:
    • List GHO on V3, with system configurations as specified in the ARFC, and supply + burn an initial seed amount (1 GHO).
    • Set ACI multisig as Emissions Manager for rewards (as provided in the ARFC.

Notes

  • after launch payload is executed (and base lane is active), seed amount will be bridged to the executor such that listing payload can be run. it is expected aave robot will only initiate execution of the listing payload when it simulates successful execution.
  • base branch is ccip_1_5_1 since we expect that AIP (upgrade eth,arb to 1.5.1) to be executed first.
  • base token is now predeployed and initialized with executor as owner.
  • all new proxies (for token pool and base gho token) are OZ v5.1

@height Height
Copy link

height bot commented Dec 23, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@DhairyaSethi
chore: upd ccip lib
be4396a
@DhairyaSethi
feat: expand _validateConfig in e2e test
ac516af
@DhairyaSethi
feat: eth & arb tests
c7b11bd
@DhairyaSethi
chore: import gho from EthereumAssets instead of MiscEthereum
c3ea819
@DhairyaSethi
chore: use latest deployment of existing remote pool upgrade
dd13655
@DhairyaSethi
doc: snapshot & discussion
9994623
@DhairyaSethi
chore: rename facilitator
2ddc813
@DhairyaSethi
test: cleanup & fuzzify
8b43b84
@DhairyaSethi
test: cleanup & fuzzify
f022cd6
@DhairyaSethi
chore: use latest deployment of existing remote pool upgrade
1e06e0d
@DhairyaSethi
doc: snapshot -> direct-to-aip
843c94a
@DhairyaSethi
chore: import gho from EthereumAssets instead of MiscEthereum
ad22759
@DhairyaSethi
chore: cleanup rm ProxyAdmin reference
b9022f6
@DhairyaSethi
chore: rename facilitator
2754acf
@DhairyaSethi
chore: rm duplicate check
ff8bd9e
@DhairyaSethi
fix: snapshot, use utils reference for chain selectors
17ec054
@DhairyaSethi
fix: base config test on eth
0471bd8
@DhairyaSethi
test: eth<>arb e2e test
cddd175
@DhairyaSethi
chore: mock naming accuracy
f866baf
DhairyaSethi and others added 5 commits January 9, 2025 14:33
@DhairyaSethi
doc: upd md with new token
6f36d41
@DhairyaSethi
feat: update gho token proxyAdmin
0a1655d
@DhairyaSethi
test: simplify
86c3cda
@Luigy-Lemon @brotherlymite
Karpatkey-Gho-Growth (bgd-labs#559)
57aaaa1 
* feat: karpatkey funding proposal - gho growth

* feat: update md file and merge main

* chore: remove unused dependencies

* chore: update aave-helper

* Update src/20241231_AaveV3Ethereum_karpatkeyGhoGrowth/karpatkeyGhoGrowth.md

Co-authored-by: Harsh Pandey <[email protected]>

---------

Co-authored-by: Harsh Pandey <[email protected]>
fix(cache): automated cache update [skip ci]
0fe7c09
@miguelmtzinf miguelmtzinf self-requested a review January 9, 2025 12:38
Rozengarden and others added 7 commits January 10, 2025 21:02
@Rozengarden
[Aavechan] ezeth on arbitrum and base (bgd-labs#561)
612e087
fix(cache): automated cache update [skip ci]
98da29e
@DhairyaSethi
chore: minor cleanup nits
cde38c6
@Rozengarden @MartinGbz
@marczeller @brotherlymite
[Aavechan] Onboard sUSDe and weETH on zksync (bgd-labs#565)
f2940b9 
* onboard USDe, sUSDe, weETH AIP

* add aip description

* make weeth borrowable in emode (to macth mainnet)

* 🐛 remove USDe from asset implemented

* 🐛 remove USDe + weETH as borrowable asset + weETH from ETH correlated emode + add new weETH correlated emode

* ✨ add weETH + ETH to new "weETH correlated" emode

* ✅ ran tests

* Update src/20250110_AaveV3ZkSync_OnboardSUSDeUSDeAndWeETHToAaveV3OnZkSync/OnboardSUSDeUSDeAndWeETHToAaveV3OnZkSync.md

Co-authored-by: Harsh Pandey <[email protected]>

* Update src/20250110_AaveV3ZkSync_OnboardSUSDeUSDeAndWeETHToAaveV3OnZkSync/OnboardSUSDeUSDeAndWeETHToAaveV3OnZkSync.md

Co-authored-by: Harsh Pandey <[email protected]>

* Update src/20250110_AaveV3ZkSync_OnboardSUSDeUSDeAndWeETHToAaveV3OnZkSync/OnboardSUSDeUSDeAndWeETHToAaveV3OnZkSync_20250110.s.sol

Co-authored-by: Harsh Pandey <[email protected]>

---------

Co-authored-by: MartinGbz <[email protected]>
Co-authored-by: Marc Zeller <[email protected]>
Co-authored-by: Harsh Pandey <[email protected]>
fix(cache): automated cache update [skip ci]
df9a022
@brotherlymite
chore: fix imports (bgd-labs#567)
763a015
@sendra
feat: a.DI Ethereum -> Celo path activation (bgd-labs#564)
47796fc 
* feat: a.DI Ethereum -> Celo path activation

* fix: add cl emergency oracle address

* fix: updated addresses of payload with new lz and hl adapters on celo

* fix: updated links to correct commit

* fix: added forum discussion link

* fix: updated aave heleprs
@nisnislevi
Copy link

This PR was verified by Certora team. No bugs were found.

DhairyaSethi and others added 12 commits January 16, 2025 23:01
@DhairyaSethi @parth-15
@miguelmtzinf @CanonicalJP
GHO CCIP 1.5.1 Upgrade Eth<>Arb (bgd-labs#557)
134c39c 
* Add proposal for Gho Incident Report 20231113 (#1)

* chore: add payload and deploy script for update of GHO variable debt token

* forge install: gho-core

* chore: add gho-core to dependency

* test: Add tests for update of gho variable token

* test: Add tests for update of gho variable token

* fix: add modifier in method of interface

* fix: remove gho dependency from repo and fix test

* fix: Remove unnecesary dependency

* fix: Add latest details

---------

Co-authored-by: miguelmtzinf <[email protected]>

* fix: Make new impl constant (#3)

* fix: Amend AIP text (#4)

* fix: Make new impl constant

* fix: Fix AIP text

* test: Tweak default tests with borrow cap update (#5)

* fix: lint issue (#6)

* test: Add diffs from test running (#7)

* fix: Add payload address (#8)

* fix: Fix payload address in script (#9)

* fix: Remove unneeded diff file (#10)

* chore: init aip

* feat: ccip 1.5.1 upgrade

* tmp: fix ci for aave org, to rm for bdg

* tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed

* tmp: fix ci for aave org

* revert: test ci secrets updates

* chore: fix comments

* chore: rm duplicate check

* chore: reorder imports, pending automation

* chore: import order

* chore: imports order, re-frame comment

* feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment

* chore: consistency, cleanup comment based on latest approach

* upd: `directMint` & `directBurn`

* feat: add `gho-core` lib temporarily, fix interface

* feat: new gho ccip steward

* feat: reference existing pool upgrade impl deployment

* feat: more verbose and efficient

* chore: upd ccip lib

* test: cleanup & fuzzify

* test: cleanup & fuzzify

* chore: use latest deployment of existing remote pool upgrade

* doc: snapshot -> direct-to-aip

* chore: import gho from EthereumAssets instead of MiscEthereum

* chore: cleanup rm ProxyAdmin reference

* chore: rename facilitator

* chore: rm duplicate check

* fix: updates based on upstream changes from bgd-labs#527

* chore: fix&add comment, use chain selector from helper lib

* chore: fix chain selector lib typo

* feat: accept existing proxy pool ownership as well

* feat: add rate limit

* feat: add deployed token pools & stewards

* feat: rm `gho-core` & `ccip`

* feat: upd arb token pool & steward deployment

* feat: notify gho bucket steward

* feat: update aave steward

* chore: use existing IOwnable

* chore: new ccip stewards with timelock getter

* feat: use oz v5.1 proxies

* doc: add discussion + spec

* feat: chainlink pre-req have been performed

* Updated GHOCCIP151Upgrade.md

* Updated GHOCCIP151Upgrade.md

Updated to permalinks

* doc: lint and add steward addresses to spec md

* doc: expand on bucket steward update

---------

Co-authored-by: Parth Patel <[email protected]>
Co-authored-by: miguelmtzinf <[email protected]>
Co-authored-by: miguelmtz <[email protected]>
Co-authored-by: JP <[email protected]>
@DhairyaSethi
feat: explicitly enable optimizer (bgd-labs#571)
0dff1b6
@Rozengarden @brotherlymite @ianflexa
[Aavechan] lbtc onboarding (bgd-labs#562)
97f99f8 
* feat: onboard LBTC

* fix cap and bump block height

* Update src/20241223_AaveV3Ethereum_EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance/EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance.md

Co-authored-by: Harsh Pandey <[email protected]>

* Update src/20241223_AaveV3Ethereum_EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance/EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance.md

Co-authored-by: Harsh Pandey <[email protected]>

* Update src/20241223_AaveV3Ethereum_EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance/config.ts

Co-authored-by: Harsh Pandey <[email protected]>

* Update src/20241223_AaveV3Ethereum_EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance/AaveV3Ethereum_EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance_20241223.sol

Co-authored-by: Ian Flexa <[email protected]>

* Update src/20241223_AaveV3Ethereum_EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance/EnableLBTCWBTCLiquidEModeOnAavev3CoreInstance.md

Co-authored-by: Ian Flexa <[email protected]>

* typo in assetListing.ts

---------

Co-authored-by: Harsh Pandey <[email protected]>
Co-authored-by: Ian Flexa <[email protected]>
fix(cache): automated cache update [skip ci]
e925716
@Rozengarden
feat: ACI emission admin for REZ, KERNEL & rsETH (bgd-labs#572)
7c4fd17 
* feat: ACI emission admin for REZ, KERNEL & rsETH

* Update SetREZKERNELAndRsETHEmissionAdminToACI.md
fix(cache): automated cache update [skip ci]
6025b91
@MartinGbz
✨ Update Prime GHO base borrow rate (bgd-labs#575)
051dd67 
* ✨ generate code

* 📝 update docs

* 🧪 run tests

* 📝 fix .md

* 📝 remove useless line
fix(cache): automated cache update [skip ci]
639d461
@DhairyaSethi
Merge branch 'main' into feat/gho-based-ccip
d1896e6
@DhairyaSethi
chore: resolve conflicts
1e54a33
@DhairyaSethi
fix: update blocks, cleanup on pre-requisites
3e6f628
@DhairyaSethi
doc: update AIP text
e6b73b8
@DhairyaSethi
Copy link
Member Author

closing in favor of bgd-labs#579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelmtzinf miguelmtzinf miguelmtzinf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@DhairyaSethi @nisnislevi @miguelmtzinf @ianflexa @Luigy-Lemon @Rozengarden @brotherlymite @sendra @MartinGbz