Unify app versioning (#222)

* unify app versioning

* enable production build flag

* minimum stack size

* bump version & update snapshots

* delete old tests snapshots

.github/workflows/main.yml

@@ -125,8 +125,8 @@ jobs:
       - name: Build NanoS
         shell: bash -l {0}
         run: |
-          COIN=DOT_MIGRATION make
-          make
+          PRODUCTION_BUILD=0 COIN=DOT_MIGRATION make
+          PRODUCTION_BUILD=0 make
           mv ./app/pkg/installer_s.sh ./app/pkg/installer_nanos.sh
           mv ./app/pkg/migration_s.sh ./app/pkg/migration_nanos.sh
       - name: Set tag
@@ -165,8 +165,8 @@ jobs:
       - name: Build NanoSP
         shell: bash -l {0}
         run: |
-          COIN=DOT_MIGRATION make
-          make
+          PRODUCTION_BUILD=0 COIN=DOT_MIGRATION make
+          PRODUCTION_BUILD=0 make
           mv ./app/pkg/installer_s2.sh ./app/pkg/installer_nanos_plus.sh
           mv ./app/pkg/migration_s2.sh ./app/pkg/migration_nanos_plus.sh
       - name: Set tag
@@ -205,8 +205,8 @@ jobs:
       - name: Build Stax
         shell: bash -l {0}
         run: |
-          COIN=DOT_MIGRATION make
-          make
+          PRODUCTION_BUILD=0 COIN=DOT_MIGRATION make
+          PRODUCTION_BUILD=0 make
       - name: Set tag
         id: stax
         run: echo "tag_name=$(./app/pkg/installer_stax.sh version)" >> $GITHUB_OUTPUT

Makefile

@@ -23,7 +23,7 @@ ifeq ($(BOLOS_SDK),)
 # When not using the SDK, we override and build the XL complete app
 
 ZXLIB_COMPILE_STAX ?= 1
-PRODUCTION_BUILD ?= 0
+PRODUCTION_BUILD ?= 1
 $(info ************ COIN  = [$(COIN)])
 include $(CURDIR)/deps/ledger-zxlib/dockerized_build.mk
 
@@ -41,6 +41,6 @@ build_all:
 
 test_all:
 	make zemu_install
-	PRODUCTION_BUILD=1 COIN=DOT_MIGRATION make
-	PRODUCTION_BUILD=1 make
+	COIN=DOT_MIGRATION make
+	make
 	make zemu_test

app/Makefile

@@ -25,10 +25,10 @@ MY_DIR := $(dir $(lastword $(MAKEFILE_LIST)))
 include $(BOLOS_SDK)/Makefile.defines
 
 # # Set the default value for HAVE_SWAP to undefined if not already defined
-# HAVE_SWAP ?= 
+# HAVE_SWAP ?=
 
 # Set the default value for PRODUCTION_BUILD to 0 if not already defined
-PRODUCTION_BUILD ?= 0
+PRODUCTION_BUILD ?= 1
 
 # Display the target name
 $(info ************ TARGET_NAME  = [$(TARGET_NAME)])
@@ -56,10 +56,7 @@ ifndef COIN
 COIN=DOT
 endif
 
-ifeq ($(COIN),DOT)
 include $(CURDIR)/Makefile.version
-endif
-
 $(info COIN  = [$(COIN)])
 
 APPPATH = "44'/354'"
@@ -92,6 +89,12 @@ $(info PATHS LIST = $(APPPATH))
 
 APP_LOAD_PARAMS = --curve ed25519 $(COMMON_LOAD_PARAMS) --path $(APPPATH)
 
+ifeq ($(TARGET_NAME),TARGET_NANOS)
+	APP_STACK_MIN_SIZE := 1600
+else
+	APP_STACK_MIN_SIZE := 1752
+endif
+
 include $(CURDIR)/../deps/ledger-zxlib/makefiles/Makefile.devices
 
 DEFAULT_ICON = nanos_$(ICON_NAME).gif

app/Makefile.migration

@@ -14,15 +14,6 @@
 #  See the License for the specific language governing permissions and
 #  limitations under the License.
 #*******************************************************************************
-
-# Versioning for Migration app
-# This is the `transaction_version` field of `Runtime`
-APPVERSION_M=100
-# This is the `spec_version` field of `Runtime`
-APPVERSION_N=0
-# This is the patch version of this release
-APPVERSION_P=1
-
 # Declare here all the allowed paths in migration app
 
 PATHS := "44'/434'" "44'/295'" "44'/523'" "44'/537'" "44'/594'" "44'/595'" "44'/617'" "44'/631'" \

app/Makefile.version

@@ -3,4 +3,4 @@ APPVERSION_M=100
 # This is the `spec_version` field of `Runtime`
 APPVERSION_N=0
 # This is the patch version of this release
-APPVERSION_P=4
+APPVERSION_P=5