-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restoring Profession Trainers in cities #385
Merged
ZhengPeiRu21
merged 16 commits into
ZhengPeiRu21:master
from
Grimfeather:Restoring-Profession-Trainers-in-cities
Oct 15, 2024
Merged
Restoring Profession Trainers in cities #385
ZhengPeiRu21
merged 16 commits into
ZhengPeiRu21:master
from
Grimfeather:Restoring-Profession-Trainers-in-cities
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores several journeyman and expert profession trainers in the Undercity
Fixed the gossip menu "train me" buttons now showing up. sorted the sql file in the same style as zone_undercity
- Fixed the gossip menu "train me" buttons now showing up for a few profession trainers. - sorted the sql file in the same style as zone_undercity - batched many inserts
This restores several journeyman and expert profession trainers in Darnassus
This restores several journeyman and expert profession trainers in Ironforge
fixed syntax error and a few more inserts batched.
- fixed the "train me" menu of the expert tailor - batched many inserts - sorted the sql in the same format as the other cities.
minor correctlions
minor corrections
minor corrections
minor layout correction
minor layout correction
Hiding alchemy artisan "train me" menu if alchemy skill is below 125
wrong gossip_menu_id again
corrected missing quest giver flag
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #182 and #371
This does require a reset of the client's cache files.