Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring Profession Trainers in cities #385

Conversation

Grimfeather
Copy link
Contributor

@Grimfeather Grimfeather commented Oct 11, 2024

Related to: #182 and #371

  • This restores many journeyman and expert profession trainers in all the vanilla cities.
  • It also fixes an issues with the "Train me" menu not showing up for trainers.
  • many batched inserts

This does require a reset of the client's cache files.

This restores several journeyman and expert profession trainers in the Undercity
Fixed the gossip menu "train me" buttons now showing up.

sorted the sql file in the same style as zone_undercity
- Fixed the gossip menu "train me" buttons now showing up for a few profession trainers.

- sorted the sql file in the same style as zone_undercity

- batched many inserts
This restores several journeyman and expert profession trainers in Darnassus
This restores several journeyman and expert profession trainers in Ironforge
fixed syntax error and a few more inserts batched.
- fixed the "train me" menu of the expert tailor
- batched many inserts
- sorted the sql in the same format as the other cities.
@Grimfeather Grimfeather marked this pull request as ready for review October 12, 2024 01:08
Hiding alchemy artisan "train me" menu if alchemy skill is below 125
wrong gossip_menu_id
again
corrected missing quest giver flag
@ZhengPeiRu21
Copy link
Owner

Thanks for the PR!

@ZhengPeiRu21 ZhengPeiRu21 merged commit 8cf7afe into ZhengPeiRu21:master Oct 15, 2024
@Grimfeather Grimfeather deleted the Restoring-Profession-Trainers-in-cities branch October 15, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants