Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Possible Missed Profession NPCs #371

Open
F-Lambda opened this issue Oct 6, 2024 · 4 comments
Open

[Bug] Possible Missed Profession NPCs #371

F-Lambda opened this issue Oct 6, 2024 · 4 comments

Comments

@F-Lambda
Copy link

F-Lambda commented Oct 6, 2024

It seems like some profession trainers were missed. Just to give an example, in zone_durotar.sql, the first aid trainer. Rawrk, is changed from using the default spellID -202007 to the spellID edited in professions.sql, -350000. However, no such change is made to the first aid trainer in Dun Murogh, Thamner Pol, meaning that the changes made there don't affect him.

-- Rawrk <First Aid Trainer>
DELETE FROM `npc_trainer` WHERE `ID`=5943;
INSERT INTO `npc_trainer` (`ID`, `SpellID`) VALUES (5943, -350000);

@Grimfeather
Copy link
Contributor

Grimfeather commented Oct 7, 2024

I looked into this. You're right. Thamner Pol should also get those changes.
Maybe he was missed because he's labeled as a Physician, not a First Aid Trainer.
I'll check the other first aid trainers as well. I'll fix this.

edit: that turned out to be quite some work. thanks for reporting this.

@F-Lambda
Copy link
Author

F-Lambda commented Oct 7, 2024

It looks like cooking trainers might have the same issue (for likely the same reason, the vast variance in titles).

@Grimfeather
Copy link
Contributor

It wasn't their title, it wasn't their faction, I don't know, some were just skipped.

I'll take a look at the cooking trainers as well then.
I think there may be many more. Darnassus had no changes yet.
If you notice anything else, please share it.

@Grimfeather
Copy link
Contributor

I checked the cooking trainers. First I thought I noticed some mistakes as well, but I think they all are as they should be.
There have already been changes made to the cooking trainers.

the spiced bread recipe is set to 200 skill requirement because it's just too convenient for a vanilla recipe.
It's still available as a collection/completionist item.
and expert and artisan training was already removed, because of the cooking book.

Did you notice anything else wrong with the cooking trainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants