Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow emojis to be set by environment variables #299

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vcokltfre
Copy link
Contributor

@vcokltfre vcokltfre commented Sep 27, 2021

Adds the ability to set custom emoji as environment variables:

  • EMOJI_CHECK
  • EMOJI_ERROR
  • EMOJI_BAN
  • EMOJI_UNBAN
  • EMOJI_NOTE
  • EMOJI_WARN
  • EMOJI_KICK
  • EMOJI_MUTE
  • EMOJI_UNMUTE
  • EMOJI_CASE_DELETED
  • EMOJI_SOFTBAN

Copy link
Collaborator

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot.env.example file should be updated

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errorMessage() function's emoji should be configurable as well.

@vcokltfre
Copy link
Contributor Author

I feel like I should add a note somewhere saying that you dont actually need the emoji env vars to run the bot, and during development you should probably just remove them, but I'm not sure where to put that. Should I add a note in the bot.env.example file or in the readme, or somewhere else?

@almeidx
Copy link
Collaborator

almeidx commented Sep 29, 2021

A comment in the env example file should be sufficient

@Dragory
Copy link
Collaborator

Dragory commented Oct 18, 2021

I think these would be a better fit for the global config, or even individual guild configs. In fact, guild configs already include the fields success_emoji and error_emoji.

@vcokltfre
Copy link
Contributor Author

Ah that's out of my abilities so I'll let someone else do that lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants