-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow emojis to be set by environment variables #299
base: master
Are you sure you want to change the base?
feat: allow emojis to be set by environment variables #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot.env.example
file should be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The errorMessage()
function's emoji should be configurable as well.
I feel like I should add a note somewhere saying that you dont actually need the emoji env vars to run the bot, and during development you should probably just remove them, but I'm not sure where to put that. Should I add a note in the |
A comment in the env example file should be sufficient |
I think these would be a better fit for the global config, or even individual guild configs. In fact, guild configs already include the fields |
Ah that's out of my abilities so I'll let someone else do that lol |
Adds the ability to set custom emoji as environment variables: