Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo correction #224

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shoaibsajid1
Copy link
Contributor

Fixed typo where restore_roles_on_mute should have been restore_roles_on_unmute

@almeidx
Copy link
Collaborator

almeidx commented Jun 2, 2021

As is, this is a breaking change. Perhaps adding backwards compatibility would be a better idea

@Dragory
Copy link
Collaborator

Dragory commented Aug 14, 2021

What @almeidx said. This should ideally be accompanied by a config preprocessor that renames the old restore_roles_on_mute value to restore_roles_on_unmute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants