Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported conversation behaviors #2896

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nashmuhandes
Copy link
Contributor

No description provided.

@RicardoLuis0
Copy link
Collaborator

RicardoLuis0 commented Jan 13, 2025

shouldn't CanTalk be (self->health > 0 && !(self->flags4 & MF4_INCOMBAT) && self->Conversation != nullptr) instead of just self->Conversation != nullptr? (possibly with another function only to check self->Conversation, ex. HasConversation())

@Boondorl
Copy link
Contributor

I thought about it but wasn't sure because the talk tracer itself only checks if it has a conversation at all and not any of the other factors. Those were specifically only checked when trying to start a conversation

@RicardoLuis0
Copy link
Collaborator

I thought about it but wasn't sure because the talk tracer itself only checks if it has a conversation at all and not any of the other factors. Those were specifically only checked when trying to start a conversation

it'd still be useful to have the two functions as different levels of checks exported, as in "can this actor talk" and "can this actor talk right now", ex. for context-senstive icons, instead of needing to try and start a conversation and have it fail

@Boondorl
Copy link
Contributor

Boondorl commented Jan 13, 2025

I'll look into updating it in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants