Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #509

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Testing #509

wants to merge 10 commits into from

Conversation

yalh76
Copy link
Member

@yalh76 yalh76 commented Dec 31, 2024

Problem

  • file log is huge

Solution

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@yalh76
Copy link
Member Author

yalh76 commented Dec 31, 2024

!testme

@yunohost-bot
Copy link

🚀
Test Badge

@yunohost-bot
Copy link

Living in the past, are we? 🐮👁️
Test Badge

@yalh76 yalh76 requested a review from Josue-T January 1, 2025 02:44
@zamentur
Copy link

Do we really need the INFO? I see fail2ban need it, but INFO write a lot of things (more than WARN...)
Maybe we should add a comment to explain changing INFO to WARN disable some fail2ban protection...

@Josue-T
Copy link

Josue-T commented Jan 15, 2025

Do we really need the INFO? I see fail2ban need it, but INFO write a lot of things (more than WARN...) Maybe we should add a comment to explain changing INFO to WARN disable some fail2ban protection...

If you want we can an option on the config panel to select "WARN log without fail2ban" or "INFO without fail2ban" and it's up to the user to select which option he want.

Or we can also create a dedicated file log for fail2ban with a really short log rotation, fail2ban probably don't need a long history and set WARN level for the main log file.

@Josue-T
Copy link

Josue-T commented Jan 15, 2025

!testme

@yunohost-bot
Copy link

🌻
Test Badge

@yunohost-bot
Copy link

Living in the past, are we? 🐮👁️
Test Badge

@Josue-T Josue-T changed the title Less logs Testing Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants