Fix buffer overflow in write_chalresp_state() #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffer was defined as CR_SALT_SIZE = 32 but number of random bytes
was CR_CHALLENGE_SIZE = 63.
Bug was introduced with commit 0972986 and on my system has the nasty side effect of corrupting the state file. So, the FIRST authentication with a buggy version works fine but the SECOND or any subsequent one breaks. It took me forever to properly bisect that.
This might be related to or even fix issue #166 as I had the same error. I am running Arch so my software is pretty much the latest version available.
Please review and merge at your discretion.
Thanks a lot,
Björn Wiedenmann