Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the levels consistent for correlation referenced rules #771

Merged

Conversation

YamatoSecurity
Copy link
Collaborator

I noticed that if you run Hayabusa with a minimum alert level of say medium, then the correlation rules with a level of medium will get a parsing error because the referenced rules were set to informational

Ex:

[WARN] Failed to parse rule. (FilePath : rules/hayabusa/builtin/Security/LogonLogoff/Logon/Sec_4648_Med_ExplicitLogon_PW-Spray_Correlation.yml) The referenced rule was not found: explicit_logon
[WARN] Failed to parse rule. (FilePath : rules/hayabusa/builtin/Security/LogonLogoff/Logon/Sec_4625_Med_LogonFail_UserGuessing_Correlation.yml) The referenced rule was not found: non_existent_user
[WARN] Failed to parse rule. (FilePath : rules/hayabusa/builtin/Security/LogonLogoff/Logon/Sec_4625_Med_LogonFail_WrongPW_PW-Guessing_Correlation.yml) The referenced rule was not found: incorrect_password

Since the referenced rules are only meant to be outputted when debugging the rule, I think I will just make sure the referenced rules have the same level as the correlation rule.

@YamatoSecurity YamatoSecurity added the bug Something isn't working label Nov 13, 2024
@YamatoSecurity YamatoSecurity self-assigned this Nov 13, 2024
Copy link
Collaborator

@fukusuket fukusuket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!🚀

@YamatoSecurity YamatoSecurity merged commit 375de85 into main Nov 13, 2024
2 checks passed
@YamatoSecurity YamatoSecurity deleted the make-alert-level-concise-for-correlation-referenced-rules branch November 13, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants