Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rule parse error check for auto PR #580

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

fukusuket
Copy link
Collaborator

@fukusuket fukusuket commented Jan 21, 2024

What Changed

  • Fixed Auto check for rule parsing errors #520
    • Run rule parsing error checking before automatic PR creation actions as follows
      • Download latest hayabusa release binary
      • Run csv-timeline command
      • Check Rule parsing error message in console
    • The above checks are done before automatic PR creation
      • If the check fails, do not create automatic PR

Test

if actions option rule-parse-error-check is true

if actions option rule-parse-error-check is false

I would appreciate it if you could review when you have time🙏

@fukusuket fukusuket added the bug Something isn't working label Jan 21, 2024
@fukusuket fukusuket self-assigned this Jan 21, 2024
Copy link
Collaborator

@YamatoSecurity YamatoSecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fukusuket Thanks so much! LGTM!

@YamatoSecurity YamatoSecurity merged commit f13330e into main Jan 21, 2024
6 checks passed
@YamatoSecurity YamatoSecurity deleted the add-rule-parse-error-check-for-auto-pr branch January 21, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto check for rule parsing errors
2 participants