Allow getting public images (#11)

* allow getting public images
YaleSpinup · Sep 14, 2021 · 51c3bb6 · 51c3bb6
1 parent 00f5fc7
commit 51c3bb6
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/ec2/images.go b/ec2/images.go
@@ -63,7 +63,6 @@ func (e *Ec2) GetImage(ctx context.Context, ids ...string) ([]*ec2.Image, error)
 	log.Infof("getting details about image ids %+v", ids)
 
 	input := ec2.DescribeImagesInput{
-		Owners:   aws.StringSlice([]string{"self"}),
 		ImageIds: aws.StringSlice(ids),
 	}
 

diff --git a/ec2/images_test.go b/ec2/images_test.go
@@ -415,7 +415,21 @@ func TestEc2_GetImage(t *testing.T) {
 				ctx: context.TODO(),
 				ids: []string{"i-00000005"},
 			},
-			want: []*ec2.Image{},
+			want: []*ec2.Image{
+				{
+					ImageId: aws.String("i-00000005"),
+					Name:    aws.String("Image_00000005"),
+					OwnerId: aws.String("aws"),
+					Public:  aws.Bool(false),
+					State:   aws.String("available"),
+					Tags: []*ec2.Tag{
+						{
+							Key:   aws.String("yale:org"),
+							Value: aws.String("dev"),
+						},
+					},
+				},
+			},
 		},
 		{
 			name:   "multiple ids",
@@ -508,6 +522,19 @@ func TestEc2_GetImage(t *testing.T) {
 						},
 					},
 				},
+				{
+					ImageId: aws.String("i-00000005"),
+					Name:    aws.String("Image_00000005"),
+					OwnerId: aws.String("aws"),
+					Public:  aws.Bool(false),
+					State:   aws.String("available"),
+					Tags: []*ec2.Tag{
+						{
+							Key:   aws.String("yale:org"),
+							Value: aws.String("dev"),
+						},
+					},
+				},
 			},
 		},
 	}