Fix filename encoding #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this line would throw an exception with the message "TypeError: decoding Unicode is not supported". The unicode() function is meant to encode raw data -- usually string objects -- and it refuses to do any decoding. The problem was that `fileName` was a unicode object, possibly because `self.dir` was itself a `unicode` object, and os.listdir() returns unicode objects if its argument is one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, line 2767 in
mosh.pywould throw an exception with the messageTypeError: decoding Unicode is not supported. Theunicodefunctionis meant to encode raw data -- usually string objects -- and it refuses
to do any decoding. The problem was that
fileNamewas a unicodeobject -- possibly because
self.dirwas itself a unicode object, andos.listdirreturns unicode objects if its argument is one.