remove dup logging

cmd/root.go

@@ -29,7 +29,6 @@ const (
 
 func NewRootCmd(iostream *iostreams.IOStreams) (*cobra.Command, error) {
 	cs := iostream.ColorScheme()
-	ctx := context.Background()
 
 	rootCmd := &cobra.Command{
 		Use:           cs.GreenBold("mycli"),
@@ -43,9 +42,10 @@ func NewRootCmd(iostream *iostreams.IOStreams) (*cobra.Command, error) {
 			ID:    "install",
 			Title: "Install commands",
 		})
-	rootCmd.AddCommand(install.NewCmdXcode(iostream))
-	rootCmd.AddCommand(install.NewCmdHomeBrew(iostream))
 
+	installCmd := install.NewInstallCmd(iostream)
+
+	rootCmd.AddCommand(installCmd)
 	rootCmd.PersistentFlags().Bool("help", false, "Show help for command")
 	if os.Getenv("GH_COBRA") == "" {
 		rootCmd.SilenceErrors = true
@@ -62,9 +62,6 @@ func NewRootCmd(iostream *iostreams.IOStreams) (*cobra.Command, error) {
 		// })
 		// rootCmd.SetFlagErrorFunc(rootFlagErrorFunc)
 	}
-	if _, err := rootCmd.ExecuteContextC(ctx); err != nil {
-		fmt.Fprintf(iostream.ErrOut, "Failed to execute root command: %v\n", err)
-	}
 	return rootCmd, nil
 }
 

pkg/commands/install/homebrew.go → pkg/commands/install/homebrew/homebrew.go

@@ -1,4 +1,4 @@
-package install
+package homebrew
 
 import (
 	"fmt"
@@ -22,7 +22,7 @@ func NewCmdHomeBrew(iostream *iostreams.IOStreams) *cobra.Command {
 		Use:   "install homebrew",
 		Short: cs.GreenBold("Install homebrew, require admin privileges, make sure enable this via privileges app"),
 		// Long:   actionsExplainer(cs),
-		GroupID:       "install",
+		//GroupID:       "install",
 		Hidden:        true,
 		SilenceErrors: true,
 		RunE: func(cmd *cobra.Command, args []string) error {

pkg/commands/install/homebrew_test.go → pkg/commands/install/homebrew/homebrew_test.go

@@ -1,4 +1,4 @@
-package install
+package homebrew
 
 import (
 	"mycli/pkg/iostreams"

pkg/commands/install/install.go

@@ -0,0 +1,42 @@
+package install
+
+import (
+	"errors"
+	"fmt"
+	"mycli/pkg/commands/install/homebrew"
+	"mycli/pkg/commands/install/xcode"
+	"mycli/pkg/iostreams"
+
+	"github.com/spf13/cobra"
+)
+
+func NewInstallCmd(iostream *iostreams.IOStreams) *cobra.Command {
+	cs := iostream.ColorScheme()
+	installCmd := &cobra.Command{
+		Use:   "install",
+		Short: "Install software",
+		Long:  `All software installation commands.`,
+		RunE: func(cmd *cobra.Command, args []string) error {
+			if len(args) == 0 { // No specific subcommand was provided
+				fmt.Fprintln(iostream.Out, cs.GreenBold("Running all installation subcommands..."))
+				for _, subcmd := range cmd.Commands() {
+					fmt.Fprintf(iostream.Out, cs.Gray("Installing %s...\n"), subcmd.Use)
+					if err := subcmd.RunE(subcmd, nil); err != nil {
+						fmt.Fprintf(iostream.ErrOut, cs.Red("Failed to install %s: %v\n"), subcmd.Use, err)
+						return err // or continue based on your policy
+					}
+				}
+				fmt.Println("All installations completed successfully.")
+				return nil
+			}
+
+			// If arguments are provided, let Cobra handle the command execution.
+			return errors.New("subcommand required")
+		},
+	}
+
+	installCmd.AddCommand(xcode.NewCmdXcode(iostream))
+	installCmd.AddCommand(homebrew.NewCmdHomeBrew(iostream))
+
+	return installCmd
+}

pkg/commands/install/xcode.go → pkg/commands/install/xcode/xcode.go

@@ -1,4 +1,4 @@
-package install
+package xcode
 
 import (
 	"fmt"
@@ -20,8 +20,8 @@ func NewCmdXcode(iostream *iostreams.IOStreams) *cobra.Command {
 		Use:   "install xcode",
 		Short: cs.GreenBold("Install xcode"),
 		// Long:   actionsExplainer(cs),
-		Hidden:        true,
-		GroupID:       "install",
+		Hidden: true,
+		//GroupID:       "install",
 		SilenceErrors: true,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			if isXcodeAlreadyInstalled() {