Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: added conventional commits check #1487

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

kuznetsss
Copy link
Collaborator

@kuznetsss kuznetsss commented Jun 24, 2024

Fixes #1366

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.81%. Comparing base (c7fee02) to head (a8002a7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1487   +/-   ##
========================================
  Coverage    67.81%   67.81%           
========================================
  Files          233      233           
  Lines         9423     9423           
  Branches      5256     5256           
========================================
  Hits          6390     6390           
  Misses        1654     1654           
  Partials      1379     1379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuznetsss kuznetsss changed the title Added conventional commits check Added conventional commits check test Jun 24, 2024
@kuznetsss kuznetsss changed the title Added conventional commits check test ci: added conventional commits check Jun 24, 2024
godexsoft
godexsoft previously approved these changes Jun 24, 2024
@kuznetsss kuznetsss changed the title ci: added conventional commits check ci: added conventional commits check Jun 24, 2024
@kuznetsss
Copy link
Collaborator Author

Check PR title works fine, but it is failing because it doesn't have write access to the repo. It will be fixed once the PR is merged.

@kuznetsss kuznetsss merged commit 062ef9f into XRPLF:develop Jun 24, 2024
17 of 19 checks passed
@kuznetsss kuznetsss deleted the 1336_Conventional_commits branch June 24, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convention for commit messages
2 participants