Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards update #1192

Merged
merged 36 commits into from
Nov 26, 2024
Merged

Rewards update #1192

merged 36 commits into from
Nov 26, 2024

Conversation

yuli-ferna
Copy link
Contributor

@yuli-ferna yuli-ferna commented Nov 25, 2024

Copy of: #1187

image

Copy link
Contributor

@Alex99y Alex99y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the subdomain changes instead of the routes, making it weird to define in the URL env part of the URL instead of the complete one. We should create a ticket to track this issue and attack it in the future in a correct way.

Approved.

@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet November 26, 2024 13:25 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Testnet November 26, 2024 13:32 — with GitHub Actions Inactive
@yuli-ferna yuli-ferna temporarily deployed to Cloudflare-Preview November 26, 2024 13:33 — with GitHub Actions Inactive
Copy link
Contributor

@sebastianscatularo sebastianscatularo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yuli-ferna yuli-ferna merged commit 6a6acb7 into main Nov 26, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants