Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revocation endpoint should be shown again for compatibility reasons #88

Closed
wants to merge 2 commits into from
Closed

feat: revocation endpoint should be shown again for compatibility reasons #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cb5ca4
Update application.yml for DDCCGW-669
shreybansod Aug 1, 2024
2c006e2
Updating for DDCCGW-669, DDCCGW-221
shreybansod Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions ...java/eu/europa/ec/dgc/gateway/restapi/controller/CertificateRevocationListController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public ResponseEntity<RevocationBatchListDto> downloadBatchList(
/**
* Endpoint to download Revocation Batch.
*/
@CertificateAuthenticationRequired(requiredRoles = CertificateAuthenticationRole.RevocationListReader)
/* @CertificateAuthenticationRequired(requiredRoles = CertificateAuthenticationRole.RevocationListReader)
@GetMapping(value = "/{batchId}", produces = {
CmsStringMessageConverter.CONTENT_TYPE_CMS_TEXT_VALUE, CmsStringMessageConverter.CONTENT_TYPE_CMS_VALUE})
@Operation(
Expand Down Expand Up @@ -203,12 +203,12 @@ public ResponseEntity<String> downloadBatch(

}
}
}
}*/

/**
* Endpoint to upload Revocation Batch.
*/
@CertificateAuthenticationRequired(requiredRoles = CertificateAuthenticationRole.RevocationUploader)
/*@CertificateAuthenticationRequired(requiredRoles = CertificateAuthenticationRole.RevocationUploader)
@PostMapping(value = "", consumes = {
CmsStringMessageConverter.CONTENT_TYPE_CMS_TEXT_VALUE, CmsStringMessageConverter.CONTENT_TYPE_CMS_VALUE})
@Operation(
Expand Down Expand Up @@ -280,12 +280,12 @@ public ResponseEntity<Void> uploadBatch(
.status(HttpStatus.CREATED)
.header(HttpHeaders.ETAG, batchId)
.build();
}
}*/

/**
* Endpoint to delete Revocation Batch.
*/
@CertificateAuthenticationRequired(requiredRoles = CertificateAuthenticationRole.RevocationDeleter)
/*@CertificateAuthenticationRequired(requiredRoles = CertificateAuthenticationRole.RevocationDeleter)
@DeleteMapping(value = "", consumes = {
CmsStringMessageConverter.CONTENT_TYPE_CMS_TEXT_VALUE, CmsStringMessageConverter.CONTENT_TYPE_CMS_VALUE})
@Operation(
Expand Down Expand Up @@ -355,18 +355,18 @@ public ResponseEntity<Void> deleteBatch(
}

return ResponseEntity.noContent().build();
}
}*/

/**
* Alternative endpoint to delete revocation batches.
*/
@CertificateAuthenticationRequired(requiredRoles = CertificateAuthenticationRole.RevocationDeleter)
/*@CertificateAuthenticationRequired(requiredRoles = CertificateAuthenticationRole.RevocationDeleter)
@PostMapping(value = "/delete", consumes = {
CmsStringMessageConverter.CONTENT_TYPE_CMS_TEXT_VALUE, CmsStringMessageConverter.CONTENT_TYPE_CMS_VALUE})
public ResponseEntity<Void> deleteBatchAlternativeEndpoint(
@RequestBody SignedStringDto batchDeleteRequest,
@RequestAttribute(CertificateAuthenticationFilter.REQUEST_PROP_COUNTRY) String countryCode) {

return deleteBatch(batchDeleteRequest, countryCode);
}
}*/
}
2 changes: 1 addition & 1 deletion src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ dgc:
pem: X-SSL-Client-Cert
revocation:
delete-threshold: 14
enabled: false
enabled: true
signer-information:
delete-threshold: 14
trustedCertificates:
Expand Down
Loading