-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twenty Ten: Fix editor styles affecting block editor UI elements #8104
base: trunk
Are you sure you want to change the base?
Twenty Ten: Fix editor styles affecting block editor UI elements #8104
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@@ -5,7 +5,8 @@ Description: Used to style the TinyMCE editor. | |||
html .mceContentBody { | |||
max-width: 640px; | |||
} | |||
* { | |||
html .mceContentBody, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sukhendu2002 Thanks for the PR. Shouldn't we update this file as well /editor-style-rtl.css
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mai-Saad, thanks for the review. yes, I will update the pr accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like other themes only use body
: would that work here?
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/twentytwelve/editor-style.css#L12
https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-content/themes/twentyfourteen/css/editor-style.css#L34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carolinan Thanks for the suggestion! The body selector is working fine in this case, so I have updated the PR accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve fixed the + icon issue and updated the PR.
@Sukhendu2002 Thanks for the PR. I applied the changes mentioned on the PR manually and can see the + is not displayed for added columns. can you please check. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/62792
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.