Resolve console error when using "Sort by" or "Order by" on Patterns page #68565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR resolves a console error that occurs when interacting with the "Sort by" or "Order by" dropdowns on the Patterns page. A null check for
contentDocument
has been added to ensure iframe initialization happens only after the iframe content is fully loaded.Why?
The error prevents the proper functioning of the Patterns page, impacting the user experience. This issue was reproducible across multiple themes and environments, as detailed in the related issue.
Related Issue: #68562
How?
The fix introduces a null check for
contentDocument
in the iframe initialization logic. This ensures that operations on the iframe are only executed when its content is available, preventing theTypeError
that previously occurred.Introduced in #38855 ( since we no longer try to initialise the iframe before the load event) another reference #51003
Testing Instructions
Screenshots or screencast