Use the correct compiler-rt #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg. when a user specifies non-default -resource-dir. cf. WebAssembly/wasi-sdk#446
|
Why does the builtins lib need to be passed to the compiler specifically when creating |
because it's suppressed by -nodefaultlibs. |
|
@alexcrichton do you have any other concerns on this PR? |
alexcrichton
approved these changes
Jul 24, 2024
yamt
added a commit
to yamt/wasi-sdk
that referenced
this pull request
Jul 25, 2024
To include WebAssembly/wasi-libc#517, which is necessary to avoid modifying host compiler's resource directory. At least on my environment (macOS if it matters), without the above mentioned fix, gmake tries to create the directory for wasi compiler-rt during wasi-libc build. I'm not sure why it didn't happen for others. cf. WebAssembly#445
alexcrichton
pushed a commit
to WebAssembly/wasi-sdk
that referenced
this pull request
Jul 25, 2024
To include WebAssembly/wasi-libc#517, which is necessary to avoid modifying host compiler's resource directory. At least on my environment (macOS if it matters), without the above mentioned fix, gmake tries to create the directory for wasi compiler-rt during wasi-libc build. I'm not sure why it didn't happen for others. cf. #445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg. when a user specifies non-default -resource-dir.
cf. WebAssembly/wasi-sdk#446