Update bindings and dependencies to WASI 0.2.0 #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Escape "." character in `sed` regex - Ensure that %.wasm target fails cleanly (i.e. without generating the target file) if `wasm-tools` fails Signed-off-by: Joel Dice <[email protected]>
sbc100
reviewed
Feb 12, 2024
We now explicitly distinquish between core module files (%.core.wasm) and component files (%.wasm), which helps avoid the trickery in my previous commit. In order to test this properly, I needed to update the Wasmtime URL to point to v17.0.0 instead of dev (which we needed to do anyway), and that in turn required updating the bindings to use the final WASI 0.2.0 release. Signed-off-by: Joel Dice <[email protected]>
dicej
changed the title
|
Any more feedback on this one? I'd like to get it merged soon-ish, since it will unblock further work on |
sbc100
reviewed
Feb 21, 2024
There was a problem hiding this comment.
I don't have any more feedback. Perhaps @sunfishcode could give final lgtm though?
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that WASI 0.2.0 has been released, we can update from the release candidate we were previously using. That includes updating various URLs in the Makefiles to point to newer deps; this is hopefully the last time we have to do that for a while. Updates include:
wasi-cliIn addition, this PR makes a couple of tweaks to the Makefiles to make them more robust:
sedregexcomponent newstep into its own rule so that we never confuse core modules with components