Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve registerExistingSFAKey docs #1032

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Improve registerExistingSFAKey docs #1032

merged 3 commits into from
Jan 9, 2025

Conversation

AyushBherwani1998
Copy link
Member

@AyushBherwani1998 AyushBherwani1998 commented Jan 9, 2025 •
edited
Loading

Motivation and Context

Jira Link:

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 10:59am

shahbaz17
shahbaz17 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@shahbaz17 shahbaz17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AyushBherwani1998 AyushBherwani1998 merged commit ca95444 into master Jan 9, 2025
5 checks passed
@AyushBherwani1998 AyushBherwani1998 deleted the mpc-core-kit-3.4.0 branch January 9, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahbaz17 shahbaz17 shahbaz17 approved these changes

Assignees
No one assigned
Labels
check-links
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyushBherwani1998 @shahbaz17