[Step2] 로또 - 2등 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NESOY
approved these changes
Jan 19, 2020
|
|
||
| private int countOfMatch; | ||
| private boolean isBonusMatch; |
There was a problem hiding this comment.
이런 전략을 하나로 추상화할 수 없을까요?
나중에 페널티 로또나, 다른 Rank 전략이 생기는 경우에 대해 확장성을 가지는 구조를 어떤 형태일까요?
| @@ -26,4 +36,9 @@ public int getPrizeMoney() { | |||
| return prizeMoney; | |||
| } | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| if (this.equals(SECOND)) return String.format("%d개 일치, 보너스 볼 일치 (%d원)", countOfMatch, prizeMoney); | |||
There was a problem hiding this comment.
한국어가 아니라 영어로 출력되는 경우에 대해 확장성있는 구조는 어떻게 가져가야할까요?
There was a problem hiding this comment.
https://github.com/WeareSoft/java-lotto/pull/7/files#r368273623
제가 단 댓글과 같은 맥락인것 같군요 😄
Delf-Lee
reviewed
Jan 19, 2020
| @@ -26,7 +26,9 @@ public int calculatePrizeMoney() { | |||
| public String toString() { | |||
There was a problem hiding this comment.
극단적으로는 출력하는 책임도 분리할 수 있을것 같습니다. 소리나 이미지로 출력하는 것 처럼요. (@toString오버라이딩 전반)
(변경안 아님)
Delf-Lee
requested changes
Jan 19, 2020
| @@ -2,7 +2,7 @@ | |||
| import java.util.List; | |||
|
|
|||
| public class LottoSeller { | |||
| private static final int PRICE = 1000; | |||
| public static final int UNIT_PRICE = 1000; | |||
There was a problem hiding this comment.
로또의 가격은 변경의 여지가 있으니, 외부에서 주입받을 수 있을 것 같습니다.
| @@ -26,4 +36,9 @@ public int getPrizeMoney() { | |||
| return prizeMoney; | |||
| } | |||
|
|
|||
| @Override | |||
| public String toString() { | |||
| if (this.equals(SECOND)) return String.format("%d개 일치, 보너스 볼 일치 (%d원)", countOfMatch, prizeMoney); | |||
There was a problem hiding this comment.
https://github.com/WeareSoft/java-lotto/pull/7/files#r368273623
제가 단 댓글과 같은 맥락인것 같군요 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test는 step3에서 작성해보겠습니다. ㅠ