Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework searching #929

Merged
merged 15 commits into from
Jan 19, 2024
Merged

Rework searching #929

merged 15 commits into from
Jan 19, 2024

Conversation

TurtIeSocks
Copy link
Collaborator

  • Splits the frontend search components into smaller chunks to make it more readable
  • Refactors the frontend code to be a lot cleaner and more consistent
  • Adds bbox limits to the query to drastically improve searching times (in some cases, quest searching goes from 700ms => 50ms)
  • Gradually increases the size of the bbox if an insufficient amount of results are found in the previous query
  • Adds invasion searching, can search by both the reward pokemon and the grunt types

Do not recommend using without this Golbat PR: UnownHash/Golbat#208

@TurtIeSocks TurtIeSocks merged commit 33178a2 into develop Jan 19, 2024
3 checks passed
@TurtIeSocks TurtIeSocks deleted the rework-searching branch January 19, 2024 20:11
Copy link

🎉 This PR is included in version 1.29.0-develop.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant