RAC-478 fix : CD workflow 수정 #335
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow file for continuous deployment, specifically changing the Docker image naming convention. The workflow now builds and pushes a Docker image with a new repository name, transitioning from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/CD-develop.yml (1)
62-63: Consider adding image cleanup and versioning strategy.A few suggestions to improve the deployment process:
- Add cleanup of old
postgraduate_developimages to prevent disk space issues- Consider using git SHA or semantic versions instead of just
latesttag for better rollback supportExample improvement:
- name: Build and Push Docker image run: | - docker build -t ywj9811/kimseonbae_develop:latest . - docker push ywj9811/kimseonbae_develop:latest + # Build with both version and latest tags + docker build -t ywj9811/kimseonbae_develop:${GITHUB_SHA::7} -t ywj9811/kimseonbae_develop:latest . + docker push ywj9811/kimseonbae_develop:${GITHUB_SHA::7} + docker push ywj9811/kimseonbae_develop:latest + + # Cleanup old images (optional) + docker rmi ywj9811/postgraduate_develop:latest || true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/CD-develop.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: SonarCloud
🔇 Additional comments (1)
.github/workflows/CD-develop.yml (1)
62-63: Verify the existence of docker-compose.kimseonbae.yml on EC2.The Docker image naming has been updated consistently, but we need to ensure the corresponding compose file exists on the EC2 instance.
Please confirm that
/home/ec2-user/config/docker-compose.kimseonbae.ymlis properly configured on the EC2 instance before merging.
🦝 PR 요약
CD workflow 수정
✨ PR 상세 내용
어떤 부분이 어떻게 변경이 되엇나요? - 지우고 작성
🚨 주의 사항
주의할 부분이 무엇인가요? - 지우고 작성
✅ 체크 리스트
Summary by CodeRabbit