Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] translation-positional-used: Limit only for >=14.0 #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moylop260
Copy link

<=13.0 does not have positional arguments:

=14.0 has positional arguments:

So, we only are limiting this check for odoo >=14.0 since past version is not already valid

<=13.0 does not have positional arguments:
 - https://github.com/odoo/odoo/blob/a03aa23461498bba67/odoo/tools/translate.py#L447

>=14.0 has positional arguments:
 - https://github.com/odoo/odoo/blob/6a6e5f92789e1c/odoo/tools/translate.py#L446

So, we only are limiting this check for odoo >=14.0 since past version is not already valid
@moylop260 moylop260 self-assigned this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant