Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] pre_commit_vauxoo: pylint checks support define python version #144

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

moylop260
Copy link
Collaborator

@moylop260 moylop260 commented Jan 10, 2025

variables.sh has 'TRAVIS_PYTHON_VERSION' with the python version to use for each project

@moylop260 moylop260 self-assigned this Jan 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.14%. Comparing base (035b03a) to head (8f2a22c).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
src/pre_commit_vauxoo/pre_commit_vauxoo.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   78.09%   80.14%   +2.04%     
==========================================
  Files           4        4              
  Lines         420      428       +8     
==========================================
+ Hits          328      343      +15     
+ Misses         92       85       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moylop260 moylop260 force-pushed the main-pyversioncfg-moy branch from 480a7f8 to c6c671e Compare January 10, 2025 21:59
All our projects have 'variables.sh' file with 'TRAVIS_PYTHON_VERSION'
with the python version to use for each project

It is useful to assign the python version to parse the code
since that the gitlab-ci image used has a particular python version
not related for each project

So, it is better to ignore the checks valid for the python version used
Using the new dockerv image OS is raising this error
@moylop260 moylop260 force-pushed the main-pyversioncfg-moy branch from c6c671e to 8f2a22c Compare January 10, 2025 22:01
@moylop260 moylop260 merged commit d210d27 into Vauxoo:main Jan 10, 2025
21 checks passed
@moylop260 moylop260 deleted the main-pyversioncfg-moy branch January 10, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants