Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New BookingComponent #32

Merged
merged 15 commits into from
Dec 16, 2024
Merged

Conversation

Dunkstormen
Copy link
Contributor

This solves #25, #21 and #17 and partially #31 as some unused packages were removed.

  • Rewritten the BookingComponent for better readability.
  • Introduced a BookingHelper instead of modules being spread across multiple tsx files in utils folder.
  • Cleaned out unused packages.
  • Introduced use of the new Positions API endpoint provided by CC.
  • Removed Snowfall due to dependency issues making the build process fail. (Put forward a PR on the react-snowfall repo, maybe it will be back soon?)

Copy link
Contributor

@thor thor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I haven't looked at prior PRs, I'll ask a dumb question that I hope you'll excuse me for.

What about moving the snowfall removal outside of this PR? Given it was added for Christmas, it seems a bit early. Alternatively, revert the React 19 upgrade if it wasn't due to a hard requirement.

src/components/BookingComponent.jsx Outdated Show resolved Hide resolved
src/utils/BookingHelper.tsx Outdated Show resolved Hide resolved
src/utils/PositionDataFetcher.tsx Outdated Show resolved Hide resolved
src/utils/BookingHelper.tsx Outdated Show resolved Hide resolved
@Dunkstormen Dunkstormen changed the title feat: New BookingComponent & removal of snow feat: New BookingComponent Dec 16, 2024
@Dunkstormen
Copy link
Contributor Author

Thanks for the contribution. I haven't looked at prior PRs, I'll ask a dumb question that I hope you'll excuse me for.

What about moving the snowfall removal outside of this PR? Given it was added for Christmas, it seems a bit early. Alternatively, revert the React 19 upgrade if it wasn't due to a hard requirement.

I've applied the suggested changes aswell as downgrading to react-18 for now. I'll keep you posted on if my PR for react-19 support gets merged.

@blt950 blt950 merged commit 97272fd into Vatsim-Scandinavia:main Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants