fix: tests related to new discord funcs

Vatsim-Scandinavia · Jan 12, 2025 · a102a30 · a102a30
1 parent 63c1d14
commit a102a30
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/app/Helpers/EventHelper.php b/app/Helpers/EventHelper.php
@@ -13,6 +13,9 @@ enum EventHelper: string
     case MONTH = 'month';
     case YEAR = 'year';
 
+    /**
+     * Get the interval labels for the event types.
+     */
     public static function labels(): array
     {
         return [
@@ -23,6 +26,10 @@ public static function labels(): array
         ];
     }
 
+    /**
+     * Get code to mention a Discord role.
+     * @codeCoverageIgnore
+     */
     public static function discordMention(): string
     {
         if (config('discord.mention_role') === null) {
@@ -32,9 +39,17 @@ public static function discordMention(): string
         return '<@&'.config('discord.mention_role').'>';
     }
 
+    /**
+     * Post a message to Discord.
+     * @codeCoverageIgnore
+     */
     public static function discordPost(string $text, string $title, string $content, ?string $image, Carbon $timestamp, ?Carbon $expireMessageAt = null): bool
     {
         $webhookUrl = config('discord.webhook');
+        if($webhookUrl === null) {
+            return false;
+        }
+
         $payload = [
             'content' => $text,
             'embeds' => [
@@ -70,9 +85,17 @@ public static function discordPost(string $text, string $title, string $content,
         return $messageId !== null;
     }
 
+    /**
+     * Delete a message from Discord.
+     * @codeCoverageIgnore
+     */
     public static function discordDelete(int $messageId): void
     {
         $webhookUrl = config('discord.webhook');
+        if($webhookUrl === null) {
+            return;
+        }
+
         Http::delete($webhookUrl."/messages/{$messageId}");
     }
 }
diff --git a/tests/Feature/Models/EventTest.php b/tests/Feature/Models/EventTest.php
@@ -138,6 +138,7 @@ public function test_normal_event_can_be_created(): void
             'recurrence_unit' => null,
             'recurrence_end_date' => null,
             'image' => $image,
+            'published' => true,
         ]);
 
         $response->assertRedirect(route('events.index'));