Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose geometry #972

Closed
wants to merge 1 commit into from
Closed

Expose geometry #972

wants to merge 1 commit into from

Conversation

jonathf
Copy link
Collaborator

@jonathf jonathf commented Aug 21, 2023

Issue

There has been a request for accessing the geometry attribute:
VROOM-Project/pyvroom#95

The attribute is unaccessible on the vroom side, so this patch exposes it so it can be read from pyvroom.

Tasks

  • review

@nilsnolde
Copy link
Contributor

nilsnolde commented Aug 21, 2023

Oops, sorry, I just realized pyvroom is already doing most things properly.. I don't know how I didn't see that last night, but there's already Input::set_geometry in pyvroom which is exactly what it needs. It's not on Solution but on Input class..

I think a few things will have to be amended (instead of exposing _geometry):

  • the Input::set_geometry of the bindings is currently a no-op, it needs to take a boolean to set the _geometry
  • the _routes_numpy conversion needs to add the geometry strings if present

Probably a bit more than that. I can look into it soon too. I'd update when working on it and let me know if you're first :)

@jonathf
Copy link
Collaborator Author

jonathf commented Aug 21, 2023

Ah, okey, there are two "geometry" references.

Closes this PR to we have correct course of action in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants