Fixed icons, manifest.json and added logo in svg format. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed links in manifest.json and browserconfig.xml. - Replaced favicons to transparent ones. - Changed linking to favicons in index.html.
- Logos view box and size set on 180x180px. - Added white version of original logo with white border and text.
|
@Blue-Hoopoe Thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, manifest.json and browserconfig.xml are not working right now - they point wrong favicons.
In addition, I changed logo to background-transparent one (based on logo in hero section).
As a bonus, I transformed existing logo to svg format (I didn't find that one in repo) and created a new, inverse version of it, so they could be easily used in the future.