Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix favorite and watchlist schemas #9

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

SubJunk
Copy link
Member

@SubJunk SubJunk commented May 18, 2024

Maybe this means you had empty watchlist and favorites lists @SurfaceS, or maybe that adult field only comes back sometimes. Anyway this change was needed to make tests pass for me

@SubJunk
Copy link
Member Author

SubJunk commented May 18, 2024

Ah there is another failure for me locally, fixing that now

@SubJunk SubJunk removed the not ready label May 18, 2024
@SubJunk
Copy link
Member Author

SubJunk commented May 18, 2024

Ok that is passing now locally

@SubJunk SubJunk requested a review from SurfaceS May 18, 2024 02:41
@SubJunk
Copy link
Member Author

SubJunk commented May 18, 2024

I also have a failure when deploying, I think because Maven changed something since the last time I did it. I will look into it soon

@SurfaceS SurfaceS merged commit cac607f into main May 18, 2024
1 check passed
@SurfaceS
Copy link

Maybe this means you had empty watchlist and favorites lists @SurfaceS, or maybe that adult field only comes back sometimes. Anyway this change was needed to make tests pass for me

No, it is only appear in the tests to tell us that something where changed.
The API still get what it know.

The test is : get json, translate to java class, translate back this java class to json, compare.
Then it tell us if we miss something (or have to much members).

I'd seen this 2 fields before, but sometime TMDB is playing around with db that add/change things.
In that case, I check on their website if the API is advising this fields, and those ones was not.

But as it is from 2 or 3 weeks from now, we can say it should be a permanent change.

@SurfaceS SurfaceS deleted the fix-favorite-watchlist-schemas branch May 18, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants