Typescript: Refine types to use proper values for tags commonly used in conjunction with pair #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EncodedVenom
changed the title
EncodedVenom
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description of your Changes.
Updated the Typescript definition file for ChildOf, OnDelete, OnDeleteTarget, Delete, and Remove so that their new type is Tags instead of Entity, which becomes
Entity<unknown>Impact of your Changes
Its a bug fix as these entities does not have any data, so it should be
Entity<undefined>notEntity<unknown>Tests Performed
Tested the types in my local machine
Additional Comments