JUP-84 tag improvements #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
move line break for database setup sections
RubenOlano
requested changes
Sep 3, 2024
README.md
Outdated
Comment on lines
107
to
111
| </details> | ||
| <details> | ||
| <summary>Tag View</summary> | ||
| there is a sql query in `src/server/db/tagView.sql` that you need to run in order for tags to work properly. | ||
| </details></br> |
There was a problem hiding this comment.
Explain why we need this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr introduces a new database view that lets us see all the unique tags and how many clubs there are for each tag, it's default ordering is also by count. This new ordering also applies to the tag listing on the homepage.
we may want to switch it to a materialized view with triggers as this information shouldn't be updated often, as view can't be indexed in postgres.