Foundation for strictmode #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few different kinds of changes are made:
- Optional parameters/variables are changed to ${var-} to default to
empty or given defaults with ${var=...}.
- ((...)) arithmetic evaluation "fails" when the result happens to be
zero, so silence this with "|| true"
This will help ensure that bashunit won't cause problems with tests that use "set -euo pipefail"
Support Bash "strict mode" (and fix one unit test)
antonio-gg-dev
force-pushed
the
strictmode
branch
from
df78662 to
e464032
Compare
Conflicts: CHANGELOG.md src/console_results.sh src/env_configuration.sh src/runner.sh
for some reason, having this set in all test files make some tests to break, and this needs some investigation. Therefore, to unblock the valid changes and enable merging them asap into main, I will remove that line from everywhere, and we can add it in a follow up PR.
Chemaclass
requested review from
khru,
JesusValeraDev,
antonio-gg-dev and
fabriziofs
|
Adding For example, And with the debug mode enabled we can already see something, but still is not clear how to fix it: Maybe @djpohly, @cmayo, @staabm might have some idea on this? 🤔
|
fabriziofs
approved these changes
Jul 12, 2024
|
no ideas on my end to this - sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Original PR: #239 by @djpohly
Some script authors like to use "unofficial Bash strict mode", enough so that supporting it shows up in comparisons of shell testing frameworks.
Case in point: enabling the -u option uncovered a bug in
test_unsuccessful_assert_is_directory_not_writablethat is fixed in this PR.🔖 Changes
$a_filewas supposed to be$a_directory).((...)), which exit 1 if their result happens to be zero, are fixed with|| true.check_duplicate_functionsdoes not appear to be intended to cause the script to fail, so it is also silenced with|| true.${1-}."${varname=default}".🏗️ Follow up
set -euo pipefailto all tests. Currently not possible; needs some more investigation [wip]✅ To-do list
CHANGELOG.mdto reflect the new feature or fix