Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update chokidar, constrain engines #852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fuzzyma
Copy link

@Fuzzyma Fuzzyma commented Nov 21, 2024

This PR updates chokidar to v4 and reduces its dependency count to 1.

It also constrains the engine field in package.json to use node versions that are supported by the tests.
Unfortunately there is not a way to only constrain it for development (since I am sure this package also runs in newer node versions once bundled). So if you want me to remove the constraint let me know.

In that case I would add a note in the readme

@Fuzzyma
Copy link
Author

Fuzzyma commented Nov 26, 2024

The CI fails because it cant install typescript because it tries to get the package from a url ending in ":". No idea where this is coming from tbh :D

@piotr-oles
Copy link
Collaborator

Looks like we have broken E2E tests:

  TypeScript SolutionBuilder API
    ✕ reports semantic error for {"async": false, "mode": "readonly", "typescript": "~4.3.0"} (34358 ms)
    ✕ reports semantic error for {"async": true, "mode": "write-tsbuildinfo", "typescript": "~4.5.0"} (34252 ms)
    ✓ reports semantic error for {"async": false, "mode": "write-references", "typescript": "~4.7.0"} (12156 ms)
    ✕ reports semantic error for {"async": true, "mode": "write-dts", "typescript": "~4.3.0"} (34042 ms)

I will take a look at them later (I'm pretty busy these days, it might take a while)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants