feat: Add linking tests #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
force-pushed
the
feature/langium-project
branch
from
aaae68e to
183a00e
Compare
montymxb
requested changes
Jan 16, 2025
msujew
force-pushed
the
feature/langium-project
branch
from
183a00e to
91e9352
Compare
Co-authored-by: Benjamin Wilson <[email protected]> Co-authored-by: Markus Rudolph <[email protected]> Signed-off-by: Mark Sujew <[email protected]>
msujew
force-pushed
the
feature/langium-project
branch
from
91e9352 to
4e07d32
Compare
didrikmunther
force-pushed
the
feature/didrik/add-linking-tests
branch
from
970b4de to
c4c7842
Compare
montymxb
reviewed
Jan 20, 2025
There was a problem hiding this comment.
This is looking good! Just one little nit about a trailing line ending, generally good practice to do. As for the state of the PR I see it's still draft, so I'll hold on any approval for now. Once the core of our work has been merged the rest of our PRs can follow, ideally.
| }) | ||
| }) | ||
| }); | ||
| }); |
There was a problem hiding this comment.
One little thing, always nice to leave a trailing new line at the end.
msujew
force-pushed
the
feature/langium-project
branch
from
4e07d32 to
279a71d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.