Implement optional back population on get operations #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `GetAsync<T>(string, bool)` overload to `ICacheStack` that allows the caller to specify if the cache entry should be back-populated to higher cache layers if it is resolved using a lower layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291.
This PR adds a new overload for
ICacheStack.GetAsync:ValueTask<CacheEntry<T>?> GetAsync<T>(string cacheKey, bool backPopulate).Specifying
falsefor thebackPopulateparameter is equivalent to calling the existingGetAsync<T>(string)overload. Specifyingtruewill use the existingGetWithLayerIndexAsyncmethod inCacheStackto determine if back population is required and, if so, runs back population using the same technique asGetOrSetAsync<T>by assigning the value task returned byBackPopulateCacheAsyncto a discard variable.I've also added unit tests to verify that back population does or does not happen as expected based on the existing tests for
GetOrSetAsync.