forked from scratchfoundation/scratch-render
-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized WebAssembly "touching" routines #3
Draft
adroitwhiz
wants to merge
14
commits into
TurboWarp:develop
Choose a base branch
from
adroitwhiz:swrender-rebase
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need to spend more time reviewing this and making sure it doesn't break things, but this is very interesting and a more mature version would probably be merged. |
I did some testing. Compatibility and performance are overall very good. Current blockers:
I can deal with the merge conflicts. |
adroitwhiz
force-pushed
the
swrender-rebase
branch
from
March 4, 2021 17:45
7395672
to
5260e2e
Compare
GarboMuffin
pushed a commit
that referenced
this pull request
Aug 15, 2024
chore: [UEPR-31] Update node version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This is a project I worked on for fun last April, which moves the software implementations of "touching" blocks from JavaScript to a WebAssembly module coded in Rust.
Reason for Changes
I benchmarked this on this project and on Chrome, it triples the speed of the "touching sprite" block.
This is a draft because the tooling is a bit rough around the edges and could stand to be better-documented, but I want to gauge interest in this.
You can test it out for yourself at https://adroitwhiz.github.io/scratch-gui/swrender/ though it's quite an old build of Scratch at the moment.
Test Coverage
All existing tests (should) pass