Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LoginNexus #1813

Closed
wants to merge 12 commits into from
Closed

LoginNexus #1813

wants to merge 12 commits into from

Conversation

Thebloxers998
Copy link

A REST API-based authentication and registration extension

Unlock the REST API-BASED authentication/registration for games

Any ideas or feedback? Tell me 💡

@Thebloxers998
Copy link
Author

(Sorry for reuploading a extension, its due to the conflicts)

yuri-kiss
yuri-kiss requested changes Dec 25, 2024
View reviewed changes
Copy link
Member

@yuri-kiss yuri-kiss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API keys are a touchy area as they are unsafe and can be easily stolen.
Please see AI extensions for reference as they require an API key and have been touched on a lot for this matter.

extensions/login-nexus.js Outdated Show resolved Hide resolved
extensions/login-nexus.js Outdated Show resolved Hide resolved
extensions/login-nexus.js Outdated Show resolved Hide resolved
extensions/login-nexus.js Outdated Show resolved Hide resolved
extensions/login-nexus.js Outdated Show resolved Hide resolved
extensions/login-nexus.js Show resolved Hide resolved
@Thebloxers998
Copy link
Author

API keys are a touchy area as they are unsafe and can be easily stolen. Please see AI extensions for reference as they require an API key and have been touched on a lot for this matter.

Api keys?

@Thebloxers998
Copy link
Author

API keys are a touchy area as they are unsafe and can be easily stolen. Please see AI extensions for reference as they require an API key and have been touched on a lot for this matter.

Api keys?

Oh, I checked the code, I did a spelling mistake

@GarboMuffin
Copy link
Member

GarboMuffin commented Dec 27, 2024 •
edited
Loading

!format

to be clear: haven't looked at this at all; this PR is just useful to test a certain edge case in the formatting script

@CubesterYT CubesterYT added the pr: new extension Pull requests that add a new extension label Dec 27, 2024
@Thebloxers998
Copy link
Author

I dont wanna add this anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuri-kiss yuri-kiss Awaiting requested review from yuri-kiss

Assignees
No one assigned
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thebloxers998 @GarboMuffin @yuri-kiss @CubesterYT @DangoCat