Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lily/ClonesPlus.js -- Fix "when I start as..." Performance, but this time it works #1761

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Lily/ClonesPlus.js -- Fix "when I start as..." Performance, but this time it works #1761

merged 1 commit into from
Nov 26, 2024

Conversation

SharkPool-SP
Copy link
Collaborator

Resolves: #1758

Now it works packaged and when opening projects :)

@SharkPool-SP SharkPool-SP requested review from CubesterYT, GarboMuffin and CST1229 and removed request for CubesterYT November 25, 2024 21:50
CubesterYT
CubesterYT approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@CubesterYT CubesterYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that it's fine now.

CST1229
CST1229 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@CST1229 CST1229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i guess

@SharkPool-SP
Copy link
Collaborator Author

Yummers

@CubesterYT CubesterYT merged commit 82dae68 into master Nov 26, 2024
3 checks passed
@CubesterYT
Copy link
Member

You better hope to god nothing else happens. Most likely not, considering we did more extensive testing this time around.

@SharkPool-SP
Copy link
Collaborator Author

You better hope to god nothing else happens. Most likely not, considering we did more extensive testing this time around.

Hopefully.

@GarboMuffin GarboMuffin mentioned this pull request Nov 27, 2024
Merged
GarboMuffin added a commit that referenced this pull request Nov 27, 2024
@GarboMuffin
Revert "Lily/ClonesPlus.js -- Fix "when I start as..." Performance, b…
e19e247 
…ut this time it works" (#1764)

Maybe tomorrow

Reverts #1761
@GarboMuffin GarboMuffin deleted the SharkPool-SP-patch-2 branch December 26, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hammouda101010 hammouda101010 hammouda101010 approved these changes

@CubesterYT CubesterYT CubesterYT approved these changes

@CST1229 CST1229 CST1229 approved these changes

@GarboMuffin GarboMuffin Awaiting requested review from GarboMuffin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clones+ "when I start as clone with [ ] set to [ ]" causes very bad performance
4 participants
@SharkPool-SP @CubesterYT @CST1229 @hammouda101010