Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Switched to eslint plugin #103

Merged
merged 1 commit into from
May 2, 2018
Merged

🎨 Switched to eslint plugin #103

merged 1 commit into from
May 2, 2018

Conversation

aileen
Copy link
Member

@aileen aileen commented Apr 16, 2018

no issue

Use our standardised eslint plugin and fix linting issues.

The commits can me squashed. I only left them separate for readability reasons.

@aileen aileen changed the title [WIP] 🎨 Switched to eslint plugin 🎨 Switched to eslint plugin Apr 16, 2018
shipitfile.js Outdated
@@ -6,14 +6,14 @@ function init(shipit) {
yarn: true,
workspace: './',
deployTo: '/opt/gscan/',
ignores: ['.git', '.gitkeep', '.gitignore', '.jshintrc', 'node_modules'],
ignores: ['.git', '.gitkeep', '.gitignore', '.jshintrc', 'node_modules']

This comment was marked as abuse.

This comment was marked as abuse.

app/index.js Outdated
@@ -76,9 +75,9 @@ app.use(function (req, res, next) {
next(new errors.NotFoundError({message: 'Page not found'}));
});

app.use(function (err, req, res, next) {
app.use(function (err, req, res) {

This comment was marked as abuse.

This comment was marked as abuse.

arr = arr || [];
inTmp = themePath.substr(0, tmpPath.length) === tmpPath;

arr = arr || [];

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

shipitfile.js Outdated
@@ -6,14 +6,14 @@ function init(shipit) {
yarn: true,
workspace: './',
deployTo: '/opt/gscan/',
ignores: ['.git', '.gitkeep', '.gitignore', '.jshintrc', 'node_modules'],
ignores: ['.git', '.gitkeep', '.gitignore', 'node_modules']

This comment was marked as abuse.

This comment was marked as abuse.

@aileen
Copy link
Member Author

aileen commented May 2, 2018

@kirrg001 This should be good to go now

@kirrg001 kirrg001 merged commit cc6396b into TryGhost:master May 2, 2018
@aileen aileen deleted the eslint branch May 10, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants