Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WarGoals data initial commit #343

Closed
wants to merge 2 commits into from

Conversation

Goosius1
Copy link
Collaborator

@Goosius1 Goosius1 commented Aug 9, 2021

Description:

  • This PR is not targeted at master, but instead at the epic branch for the WarGoals feature.
  • The idea is to build the WarGoals feature using multiple small PR's to the epic branch, then finally when a pre-releasable version is implemented and tested, merge the epic branch to master.
    • Advantage: Each PR can be small.
    • Disadvantage: Each PR will only deliver only part of the required code, so most early PR's won't be testable for game effects.
    • However, each PR can be reviewed for syntax errors, logic errors, any applicable standards etc.
  • This particular PR adds the metadata support needed for the feature
  • Note that currently the design is quite fluid, so it to avoid confusion with changing requirements, I suggest reviewers focus on more general aspects in the early PR's.

New Nodes/Commands/ConfigOptions:

N/A


Relevant Issue ticket:

Part of #335


  • [N/A] I have tested this pull request for defects on a server.

By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.

@Goosius1 Goosius1 self-assigned this Aug 9, 2021
@Goosius1 Goosius1 changed the title Wargoals data initial commit WarGoals data initial commit Aug 9, 2021
@Goosius1
Copy link
Collaborator Author

  • On hold for now.
  • I have an alternative idea which I am currently pursuing to deal with war motivations.

@Goosius1 Goosius1 closed this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant