-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Haskell LTS version to 18.28 #5
Open
gijsvcuyck
wants to merge
12
commits into
TorXakis:master
Choose a base branch
from
gijsvcuyck:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NoTrace library seemed to be unmaintained and required a very old version of ghc. By adding the files directly to the project, the maximum version of the compiler could be increased in the NoTrace.cabal file.
…et library. Network.Socket.close' already seems to cover most if not all functionality of the old custom closeIfOpen function. The old function was using several depricated apis, and was therfore no longer maintainable. Also added a test to check if the new implementation of getfreeSocket can sucessfully create multiple sockets, instead of creating multiple instances of the same socket.
Socket version increase
…esulted in problems when using this library in other projects.
…eation can be reused, as this was removed from the Network module.
…work library. Mimics acceptOn method, but stops before actually making the connection.
…omplaining about support for hpack and package.yaml files being deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the LTS version used by the project, allowing the use of the haskell-language-server implementation of the LSP for IDE support while developing.