documentation: add cookie consent and new analytics #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because it needs to be checked how it looks like. |
michaelwood
reviewed
Apr 4, 2022
BibianaC
commented
Apr 4, 2022
| @@ -168,21 +168,9 @@ | |||
|
|
|||
| </div> | |||
|
|
|||
| {# Do not conflict with RTD insertion of analytics script #} | |||
| {% if not READTHEDOCS %} | |||
There was a problem hiding this comment.
@drkane this was added by you. By adding the new cookie-consent analytics, do we need to keep it or is it save to delete it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.