-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update library dependencies #7
Update library dependencies #7
Conversation
Daffy 0.6.0 conflicts currently with pandas >=2.0.0 versions since it depends on pandas (>=1.5.1,<2.0.0)
Referred to the changes in own pyproject.toml: daffy = { git = "https://github.com/MatiasTiainen/daffy.git", branch = "chore/support-pandas-2.0.0-and-newer" } And the run successfully: poetry self add poetry-plugin-up
poetry up --latest which resulted in our project to update pandas from 1.5.3 -> 2.1.3 successfully without conflicts as previously |
Do you @laurimak have permission to approve the workflow and then merge this branch to the master? |
It seems I don't have the permission. @H-J-Kasurinen, could please give a hand :) |
GitHub Actions main.yml workflow failed since I also included minor fine-tuning where I updated GitHub Actions in main.yml, and aligned |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 73 73
Branches 14 17 +3
=========================================
Hits 73 73 ☔ View full report in Codecov by Sentry. |
Thanks @MatiasTiainen ! Closes #6 |
What
In this PR, we update library dependencies to support pandas >=2.0.0 versions to be used with this library
Why
It is best practice to have up-to-date dependencies since currently, the library does not support pandas >=2.0.0 and thus requires other projects to have pandas <2.0.0
Good-to-know
Successfully managed to update dependencies with this fork that previously conflicted. Related to this Issue: https://github.com/fourkind/daffy/issues which I seem to be unable to link to this PR