Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for 1.17 #69

Open
wants to merge 28 commits into
base: 1.16-fabric
Choose a base branch
from
Open

Conversation

quiqueck
Copy link

@quiqueck quiqueck commented Jun 23, 2021

Compiles and runs on 1.17. However, there are some important issues that need to get addressed:

  • Config is saved using Jankson instead of TOML. This means that old settings are not loaded. The TOML-serializer in v5-series of ClothConfig appears to have some issues and crashes when an existing toml is read.
  • DeathChestState.onBlockEntityUnload used getUnloadedBlockEntities to determine if it was called due to a chunk unload. That function (and the underlying list) is no longer available. I implemented an alternative checking wether or not the content of the chest is empty. But this may be a bad idea
  • DeathChest creation works for default settings, but this definitely needs some testing
  • I am using a local fabric.gradle that contains fixes dependencies that change for 1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant