-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add dev container infrastructure #4842
Closed
ianjmacintosh
wants to merge
24
commits into
TheOdinProject:main
from
ianjmacintosh:add-devcontainer-via-docker-compose
Closed
chore: Add dev container infrastructure #4842
ianjmacintosh
wants to merge
24
commits into
TheOdinProject:main
from
ianjmacintosh:add-devcontainer-via-docker-compose
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d45b7f6.
If someone needs it, they can install it on their own
Also correct the install instructions for Chrome
Set postgres credentials
rbenv and rvm cannot live side-by-side
Also remove unnecessary comment about .env
Also add some instructions for how to get started
Maybe the failures from before were due to bad syntax?
Hey @ianjmacintosh, we appreciate you taking the time to do this. But we talked it over within the team, and it isn't something we'd be willing to maintain at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
I wanted to contribute to this project but setup took me a while. These changes will help other engineers get up and running with a remote dev environment running this project dramatically faster than manually going through the local setup process.
Using GitHub Codespaces' free tier, I can push a button directly within the GitHub web UI and have a brand new isolated environment running The Odin Project in about 5 minutes
This PR
Additional Information
Although I mention GitHub Codespaces because it's what I personally use, other organizations like CodeSandbox and DevPod also support dev containers, I'm just much less familiar with them.
To try it out yourself, pull this branch to your fork, navigate to it in the GitHub UI, and from the "Code" dropdown choose "+" to create a new workspace:
After your codespace is up and running, type
bin/dev
in your terminal to start your web server. VS Code Web will open a dialog window telling you how to connect in your web browser. The URL will look something like:Pull Request Requirements
keyword: brief description of change
format, using one of the following keywords:Feature
- adds new or amends existing user-facing behaviorChore
- changes that have no user-facing value, refactors, dependency bumps, etcFix
- bug fixesBecause
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section