Update README.md with a note about event bug in tx #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that under certain conditions Z can send an event twice. This doesn't seem to be a problem anywhere in Webaverse except where we were having the avatar trigger twice, and rearranging the code fixed that. Adding a note in case someone else comes across this issue in the future. I don't think that we necessarily should change ZJS by adding a check unless it becomes a problem since it works as expected in the app if you follow the convention. I wouldn't even necessarily describe it as a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that under certain conditions Z can send an event twice. This doesn't seem to be a problem anywhere in Webaverse except where we were having the avatar trigger twice, and rearranging the code fixed that. Adding a note in case someone else comes across this issue in the future. I don't think that we necessarily should change ZJS by adding a check unless it becomes a problem since it works as expected in the app if you follow the convention. I wouldn't even necessarily describe it as a bug.