gpl: activate revert if diverge for nangate45/bp_be #2700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
oharboe
suggested changes
Jan 22, 2025
flow/scripts/global_place.tcl
Outdated
| @@ -9,6 +9,10 @@ fast_route | |||
|
|
|||
| set global_placement_args {} | |||
|
|
|||
| if {[info exists ::env(GPL_ALLOW_REVERT_IF_DIVERGE)] && $::env(GPL_ALLOW_REVERT_IF_DIVERGE)} { | |||
| lappend global_placement_args {-allow_revert_if_diverge} | |||
There was a problem hiding this comment.
Use append_env_var for consistency and to avoid repeating tiny bugs
oharboe
reviewed
Jan 22, 2025
| {*}$::env(GLOBAL_PLACEMENT_ARGS) | ||
| -pad_right $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT)] \ | ||
| $global_placement_args] | ||
|
|
oharboe
reviewed
Jan 22, 2025
| @@ -5,10 +5,20 @@ load_design 2_floorplan.odb 2_floorplan.sdc | |||
| if { [env_var_exists_and_non_empty FLOORPLAN_DEF] } { | |||
| puts "FLOORPLAN_DEF is set. Skipping global placement without IOs" | |||
| } else { | |||
| log_cmd global_placement -skip_io -density [place_density_with_lb_addon] \ | |||
|
|
|||
| set global_placement_args {} | |||
There was a problem hiding this comment.
no need to introduce new var, just use append_env_var after set all_args below
There was a problem hiding this comment.
We would not need the "global_placement_args" in global_place.tcl too if we move the setting of all parameters inside of do_placement, right?
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
Signed-off-by: Augusto Berndt <[email protected]>
oharboe
reviewed
Jan 22, 2025
flow/scripts/variables.yaml
Outdated
| @@ -379,6 +379,12 @@ DPO_MAX_DISPLACEMENT: | |||
| description: > | |||
| Specifies how far an instance can be moved when optimizing. | |||
| default: 5 1 | |||
| GPL_ALLOW_REVERT_IF_DIVERGE: | |||
| description: > | |||
| Enable reverting to saved snapshot if a divergence is detected. | |||
There was a problem hiding this comment.
this could do with a bit of elaboration. When would the user use this?
Also, isn't this a stopgap feature? Worth mentioning.
Signed-off-by: Augusto Berndt <[email protected]>
oharboe
approved these changes
Jan 23, 2025
|
I am going to close this PR because in OR PR we decided to maintain the "revert if diverge" as default behavior, so we don't need to activate it for a specific designs anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR activates the new option implemented in PR The-OpenROAD-Project/OpenROAD#6561 for nangate45/bp_be, and solves the issue in The-OpenROAD-Project/OpenROAD#6542.